Skip to content

Commit

Permalink
Staging: hv: mouse_vsc: fix comment coding style
Browse files Browse the repository at this point in the history
Also mark this as a nice FIXME as we shouldn't ever
care about the value of an atomic variable, which makes me seriously
doubt the validity of this reference counting code.  Odds are it can be
ripped out completly, or at the very least, converted to using a kref.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Mar 3, 2011
1 parent 6a5bfc1 commit e1f1a0e
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions drivers/staging/hv/mouse_vsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,14 @@ static inline struct mousevsc_dev *GetInputDevice(struct hv_device *Device)

inputDevice = (struct mousevsc_dev *)Device->ext;

// printk(KERN_ERR "-------------------------> REFCOUNT = %d",
// inputDevice->RefCount);
/*
* FIXME
* This sure isn't a valid thing to print for debugging, no matter
* what the intention is...
*
* printk(KERN_ERR "-------------------------> REFCOUNT = %d",
* inputDevice->RefCount);
*/

if (inputDevice && atomic_read(&inputDevice->RefCount) > 1)
atomic_inc(&inputDevice->RefCount);
Expand Down

0 comments on commit e1f1a0e

Please sign in to comment.