Skip to content

Commit

Permalink
of_mdio: Honour "status=disabled" property of device
Browse files Browse the repository at this point in the history
Currently of_mdiobus_register() function registers all PHY devices,
independetly from their status property in device tree. According to
"ePAPR 1.1" spec, device should only be registered if there is no
"status" property, or it has "ok" (or "okay") value (see
of_device_is_available()). In case of "platform devices",
of_platform_device_create_pdata() checks for "status" and ensures
that disabled devices are not pupulated. But such check for MDIO buses
was missing until now. Fix it.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Alexander Sverdlin authored and Grant Likely committed Nov 29, 2012
1 parent 4447ca1 commit e207e76
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/of/of_mdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
return rc;

/* Loop over the child nodes and register a phy_device for each one */
for_each_child_of_node(np, child) {
for_each_available_child_of_node(np, child) {
const __be32 *paddr;
u32 addr;
int len;
Expand Down

0 comments on commit e207e76

Please sign in to comment.