Skip to content

Commit

Permalink
staging/comedi: Use dev_ printks in drivers/ii_pci20kc.c
Browse files Browse the repository at this point in the history
fixed below checkpatch warnings.
- WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
YAMANE Toshiaki authored and Greg Kroah-Hartman committed Oct 22, 2012
1 parent 66ae18f commit e209939
Showing 1 changed file with 15 additions and 20 deletions.
35 changes: 15 additions & 20 deletions drivers/staging/comedi/drivers/ii_pci20kc.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,13 +216,13 @@ static int pci20xxx_attach(struct comedi_device *dev,

/* Check PCI-20001 C-2A Carrier Board ID */
if ((readb(devpriv->ioaddr) & PCI20000_ID) != PCI20000_ID) {
printk(KERN_WARNING "comedi%d: ii_pci20kc PCI-20001"
" C-2A Carrier Board at base=0x%p not found !\n",
dev->minor, devpriv->ioaddr);
dev_warn(dev->class_dev,
"PCI-20001 C-2A Carrier Board at base=0x%p not found !\n",
devpriv->ioaddr);
return -EINVAL;
}
printk(KERN_INFO "comedi%d: ii_pci20kc: PCI-20001 C-2A at base=0x%p\n",
dev->minor, devpriv->ioaddr);
dev_info(dev->class_dev, "PCI-20001 C-2A at base=0x%p\n",
devpriv->ioaddr);

for (i = 0; i < PCI20000_MODULES; i++) {
s = &dev->subdevices[i];
Expand All @@ -235,23 +235,21 @@ static int pci20xxx_attach(struct comedi_device *dev,
devpriv->ioaddr + (i + 1) * PCI20000_OFFSET;
pci20006_init(dev, s, it->options[2 * i + 2],
it->options[2 * i + 3]);
printk(KERN_INFO "comedi%d: "
"ii_pci20kc PCI-20006 module in slot %d\n",
dev->minor, i + 1);
dev_info(dev->class_dev,
"PCI-20006 module in slot %d\n", i + 1);
break;
case PCI20341_ID:
sdp->pci20341.iobase =
devpriv->ioaddr + (i + 1) * PCI20000_OFFSET;
pci20341_init(dev, s, it->options[2 * i + 2],
it->options[2 * i + 3]);
printk(KERN_INFO "comedi%d: "
"ii_pci20kc PCI-20341 module in slot %d\n",
dev->minor, i + 1);
dev_info(dev->class_dev,
"PCI-20341 module in slot %d\n", i + 1);
break;
default:
printk(KERN_WARNING "ii_pci20kc: unknown module "
"code 0x%02x in slot %d: module disabled\n",
id, i); /* XXX this looks like a bug! i + 1 ?? */
dev_warn(dev->class_dev,
"unknown module code 0x%02x in slot %d: module disabled\n",
id, i); /* XXX this looks like a bug! i + 1 ?? */
/* fall through */
case PCI20xxx_EMPTY_ID:
s->type = COMEDI_SUBD_UNUSED;
Expand Down Expand Up @@ -347,8 +345,7 @@ static int pci20006_insn_write(struct comedi_device *dev,
writeb(0x00, sdp->iobase + PCI20006_STROBE1);
break;
default:
printk(KERN_WARNING
" comedi%d: pci20xxx: ao channel Error!\n", dev->minor);
dev_warn(dev->class_dev, "ao channel Error!\n");
return -EINVAL;
}

Expand Down Expand Up @@ -463,10 +460,8 @@ static int pci20341_insn_read(struct comedi_device *dev,
eoc = readb(sdp->iobase + PCI20341_STATUS_REG);
}
if (j >= 100) {
printk(KERN_WARNING
"comedi%d: pci20xxx: "
"AI interrupt channel %i polling exit !\n",
dev->minor, i);
dev_warn(dev->class_dev,
"AI interrupt channel %i polling exit !\n", i);
return -EINVAL;
}
lo = readb(sdp->iobase + PCI20341_LDATA);
Expand Down

0 comments on commit e209939

Please sign in to comment.