Skip to content

Commit

Permalink
[PATCH] b44: check link state during open
Browse files Browse the repository at this point in the history
Check the link state during b44_open.  This closes a 1 HZ window
that existed after b44_open ran but before the b44_timer handler ran,
during which ethtool would report "Link detected: yes" no matter what
the link state actually was.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
John W. Linville authored and Jeff Garzik committed Jun 27, 2005
1 parent 1fe2cb3 commit e254e9b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/b44.c
Original file line number Diff line number Diff line change
Expand Up @@ -1285,6 +1285,9 @@ static int b44_open(struct net_device *dev)
b44_init_hw(bp);
bp->flags |= B44_FLAG_INIT_COMPLETE;

netif_carrier_off(dev);
b44_check_phy(bp);

spin_unlock_irq(&bp->lock);

init_timer(&bp->timer);
Expand Down

0 comments on commit e254e9b

Please sign in to comment.