Skip to content

Commit

Permalink
Staging: vt6656: Clean up return from sending power state notifications
Browse files Browse the repository at this point in the history
Clean up power.c so that unnecessary final return statements
are not used when sending power state notifications to
the access point.

Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Philip Worrall authored and Greg Kroah-Hartman committed Mar 2, 2011
1 parent 036dba1 commit e25b75e
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions drivers/staging/vt6656/power.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ void PSvEnablePowerSaving(void *hDeviceContext,

pDevice->bPWBitOn = TRUE;
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "PS:Power Saving Mode Enable... \n");
return;
}

/*
Expand Down Expand Up @@ -163,7 +162,6 @@ void PSvDisablePowerSaving(void *hDeviceContext)
PSbSendNullPacket(pDevice);

pDevice->bPWBitOn = FALSE;
return;
}

/*
Expand Down Expand Up @@ -255,13 +253,10 @@ void PSvSendPSPOLL(void *hDeviceContext)
pTxPacket->cbMPDULen = WLAN_HDR_ADDR2_LEN;
pTxPacket->cbPayloadLen = 0;

/* send the frame */
/* log failure if sending failed */
if (csMgmt_xmit(pDevice, pTxPacket) != CMD_STATUS_PENDING) {
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "Send PS-Poll packet failed..\n");
} else {
/* DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "Send PS-Poll packet success..\n"); */
};
return;
}
}

/*
Expand Down Expand Up @@ -316,15 +311,12 @@ BOOL PSbSendNullPacket(void *hDeviceContext)
memcpy(pTxPacket->p80211Header->sA3.abyAddr3, pMgmt->abyCurrBSSID, WLAN_BSSID_LEN);
pTxPacket->cbMPDULen = WLAN_HDR_ADDR3_LEN;
pTxPacket->cbPayloadLen = 0;
/* send the frame */
/* log error if sending failed */
if (csMgmt_xmit(pDevice, pTxPacket) != CMD_STATUS_PENDING) {
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "Send Null Packet failed !\n");
return FALSE;
} else {
/* DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "Send Null Packet success....\n"); */
}

return TRUE ;
return TRUE;
}

/*
Expand Down

0 comments on commit e25b75e

Please sign in to comment.