Skip to content

Commit

Permalink
staging: comedi: pcl816: if test should use logical OR not bitwise OR
Browse files Browse the repository at this point in the history
This quiets a couple sparse warnings about:

warning: dubious: !x | !y
warning: dubious: x | !y

Also, remove the unnecessary parentheses abound the variables.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jun 11, 2012
1 parent 0bdf8ec commit e26d925
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/staging/comedi/drivers/pcl816.c
Original file line number Diff line number Diff line change
Expand Up @@ -414,8 +414,8 @@ static irqreturn_t interrupt_pcl816(int irq, void *d)
}

outb(0, dev->iobase + PCL816_CLRINT); /* clear INT request */
if ((!dev->irq) | (!devpriv->irq_free) | (!devpriv->irq_blocked) |
(!devpriv->int816_mode)) {
if (!dev->irq || !devpriv->irq_free || !devpriv->irq_blocked ||
!devpriv->int816_mode) {
if (devpriv->irq_was_now_closed) {
devpriv->irq_was_now_closed = 0;
/* comedi_error(dev,"last IRQ.."); */
Expand Down

0 comments on commit e26d925

Please sign in to comment.