Skip to content

Commit

Permalink
perf: Round robin flexible groups of events using list_rotate_left()
Browse files Browse the repository at this point in the history
This is more proper that doing it through a list_for_each_entry()
that breaks after the first entry.

v2: Don't rotate pinned groups as its not needed to time share
them.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>
  • Loading branch information
Frederic Weisbecker committed Jan 16, 2010
1 parent 5908cdc commit e286417
Showing 1 changed file with 4 additions and 13 deletions.
17 changes: 4 additions & 13 deletions kernel/perf_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -1454,25 +1454,16 @@ static void perf_ctx_adjust_freq(struct perf_event_context *ctx)
*/
static void rotate_ctx(struct perf_event_context *ctx)
{
struct perf_event *event;

if (!ctx->nr_events)
return;

raw_spin_lock(&ctx->lock);
/*
* Rotate the first entry last (works just fine for group events too):
*/

/* Rotate the first entry last of non-pinned groups */
perf_disable();
list_for_each_entry(event, &ctx->pinned_groups, group_entry) {
list_move_tail(&event->group_entry, &ctx->pinned_groups);
break;
}

list_for_each_entry(event, &ctx->flexible_groups, group_entry) {
list_move_tail(&event->group_entry, &ctx->flexible_groups);
break;
}
list_rotate_left(&ctx->flexible_groups);

perf_enable();

raw_spin_unlock(&ctx->lock);
Expand Down

0 comments on commit e286417

Please sign in to comment.