Skip to content

Commit

Permalink
net: ns83820: remove unnecessary pci_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jingoo Han authored and David S. Miller committed Dec 9, 2013
1 parent add0cdb commit e28f4d5
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/ethernet/natsemi/ns83820.c
Original file line number Diff line number Diff line change
Expand Up @@ -2235,7 +2235,6 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
pci_disable_device(pci_dev);
out_free:
free_netdev(ndev);
pci_set_drvdata(pci_dev, NULL);
out:
return err;
}
Expand All @@ -2259,7 +2258,6 @@ static void ns83820_remove_one(struct pci_dev *pci_dev)
dev->rx_info.descs, dev->rx_info.phy_descs);
pci_disable_device(dev->pci_dev);
free_netdev(ndev);
pci_set_drvdata(pci_dev, NULL);
}

static DEFINE_PCI_DEVICE_TABLE(ns83820_pci_tbl) = {
Expand Down

0 comments on commit e28f4d5

Please sign in to comment.