Skip to content

Commit

Permalink
USB: serial: Note mos7480 and option don't lock modem status
Browse files Browse the repository at this point in the history 
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alan Cox authored and Greg Kroah-Hartman committed Apr 25, 2008
1 parent 9b0f258 commit e298449
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/usb/serial/mos7840.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1722,6 +1722,7 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file,
if (mos7840_port == NULL)
return -ENODEV;

/* FIXME: What locks the port registers ? */
mcr = mos7840_port->shadowMCR;
if (clear & TIOCM_RTS)
mcr &= ~MCR_RTS;
Expand Down
1 change: 1 addition & 0 deletions drivers/usb/serial/option.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,7 @@ static int option_tiocmset(struct usb_serial_port *port, struct file *file,

portdata = usb_get_serial_port_data(port);

/* FIXME: what locks portdata fields ? */
if (set & TIOCM_RTS)
portdata->rts_state = 1;
if (set & TIOCM_DTR)
Expand Down

0 comments on commit e298449

Please sign in to comment.