Skip to content

Commit

Permalink
bcma: return the mips irq number in bcma_core_irq
Browse files Browse the repository at this point in the history
The irq signal numbers that are send by the cpu are increased by 2 from
the number programmed into the mips core by bcma.
Return the irq number on which the irqs are send in bcma_core_irq() now.

Signed-off-by: Nathan Hintz <nlhintz@hotmail.com>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Nathan Hintz authored and John W. Linville committed Jan 11, 2013
1 parent 1a2d503 commit e2aa19f
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion arch/mips/bcm47xx/serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ static int __init uart8250_init_bcma(void)

p->mapbase = (unsigned int) bcma_port->regs;
p->membase = (void *) bcma_port->regs;
p->irq = bcma_port->irq + 2;
p->irq = bcma_port->irq;
p->uartclk = bcma_port->baud_base;
p->regshift = bcma_port->reg_shift;
p->iotype = UPIO_MEM;
Expand Down
2 changes: 1 addition & 1 deletion drivers/bcma/driver_chipcommon.c
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ void bcma_chipco_serial_init(struct bcma_drv_cc *cc)
return;
}

irq = bcma_core_mips_irq(cc->core);
irq = bcma_core_irq(cc->core);

/* Determine the registers of the UARTs */
cc->nr_serial_ports = (cc->capabilities & BCMA_CC_CAP_NRUART);
Expand Down
12 changes: 9 additions & 3 deletions drivers/bcma/driver_mips.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ static u32 bcma_core_mips_irqflag(struct bcma_device *dev)
* If disabled, 5 is returned.
* If not supported, 6 is returned.
*/
unsigned int bcma_core_mips_irq(struct bcma_device *dev)
static unsigned int bcma_core_mips_irq(struct bcma_device *dev)
{
struct bcma_device *mdev = dev->bus->drv_mips.core;
u32 irqflag;
Expand All @@ -102,7 +102,13 @@ unsigned int bcma_core_mips_irq(struct bcma_device *dev)

return 5;
}
EXPORT_SYMBOL(bcma_core_mips_irq);

unsigned int bcma_core_irq(struct bcma_device *dev)
{
unsigned int mips_irq = bcma_core_mips_irq(dev);
return mips_irq <= 4 ? mips_irq + 2 : 0;
}
EXPORT_SYMBOL(bcma_core_irq);

static void bcma_core_mips_set_irq(struct bcma_device *dev, unsigned int irq)
{
Expand Down Expand Up @@ -299,7 +305,7 @@ void bcma_core_mips_init(struct bcma_drv_mips *mcore)
break;
default:
list_for_each_entry(core, &bus->cores, list) {
core->irq = bcma_core_mips_irq(core) + 2;
core->irq = bcma_core_irq(core);
}
bcma_err(bus,
"Unknown device (0x%x) found, can not configure IRQs\n",
Expand Down
4 changes: 2 additions & 2 deletions drivers/bcma/driver_pci_host.c
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ int bcma_core_pci_plat_dev_init(struct pci_dev *dev)
pr_info("PCI: Fixing up device %s\n", pci_name(dev));

/* Fix up interrupt lines */
dev->irq = bcma_core_mips_irq(pc_host->pdev->core) + 2;
dev->irq = bcma_core_irq(pc_host->pdev->core);
pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq);

return 0;
Expand All @@ -596,6 +596,6 @@ int bcma_core_pci_pcibios_map_irq(const struct pci_dev *dev)

pc_host = container_of(dev->bus->ops, struct bcma_drv_pci_host,
pci_ops);
return bcma_core_mips_irq(pc_host->pdev->core) + 2;
return bcma_core_irq(pc_host->pdev->core);
}
EXPORT_SYMBOL(bcma_core_pci_pcibios_map_irq);
2 changes: 1 addition & 1 deletion include/linux/bcma/bcma_driver_mips.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ static inline void bcma_core_mips_early_init(struct bcma_drv_mips *mcore) { }

extern u32 bcma_cpu_clock(struct bcma_drv_mips *mcore);

extern unsigned int bcma_core_mips_irq(struct bcma_device *dev);
extern unsigned int bcma_core_irq(struct bcma_device *core);

#endif /* LINUX_BCMA_DRIVER_MIPS_H_ */

0 comments on commit e2aa19f

Please sign in to comment.