Skip to content

Commit

Permalink
ixgbevf: Drop use of eitr_low and eitr_high for hard coded values
Browse files Browse the repository at this point in the history
This patch drops the use of eitr_low and eitr_high as values being stored
in the adapter structure.  Since the values have no external way to be
changed they might as well just be hard coded values and save us the space
on the adapter structure.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
Alexander Duyck authored and Jeff Kirsher committed Jul 17, 2012
1 parent 525a940 commit e2c28ce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
2 changes: 0 additions & 2 deletions drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,6 @@ struct ixgbevf_adapter {

/* Interrupt Throttle Rate */
u32 itr_setting;
u16 eitr_low;
u16 eitr_high;

/* TX */
struct ixgbevf_ring *tx_ring; /* One per active queue */
Expand Down
12 changes: 4 additions & 8 deletions drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -704,17 +704,17 @@ static u8 ixgbevf_update_itr(struct ixgbevf_adapter *adapter,

switch (itr_setting) {
case lowest_latency:
if (bytes_perint > adapter->eitr_low)
if (bytes_perint > 10)
retval = low_latency;
break;
case low_latency:
if (bytes_perint > adapter->eitr_high)
if (bytes_perint > 20)
retval = bulk_latency;
else if (bytes_perint <= adapter->eitr_low)
else if (bytes_perint <= 10)
retval = lowest_latency;
break;
case bulk_latency:
if (bytes_perint <= adapter->eitr_high)
if (bytes_perint <= 20)
retval = low_latency;
break;
}
Expand Down Expand Up @@ -2069,10 +2069,6 @@ static int __devinit ixgbevf_sw_init(struct ixgbevf_adapter *adapter)
adapter->eitr_param = 20000;
adapter->itr_setting = 1;

/* set defaults for eitr in MegaBytes */
adapter->eitr_low = 10;
adapter->eitr_high = 20;

/* set default ring sizes */
adapter->tx_ring_count = IXGBEVF_DEFAULT_TXD;
adapter->rx_ring_count = IXGBEVF_DEFAULT_RXD;
Expand Down

0 comments on commit e2c28ce

Please sign in to comment.