Skip to content

Commit

Permalink
padata: cpu hotplug code should depend on CONFIG_HOTPLUG_CPU
Browse files Browse the repository at this point in the history
This patch makes the padata cpu hotplug code dependend on CONFIG_HOTPLUG_CPU.

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Steffen Klassert authored and Herbert Xu committed May 3, 2010
1 parent df2071b commit e2cb2f1
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions kernel/padata.c
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,7 @@ void padata_stop(struct padata_instance *pinst)
}
EXPORT_SYMBOL(padata_stop);

#ifdef CONFIG_HOTPLUG_CPU
static int padata_cpu_callback(struct notifier_block *nfb,
unsigned long action, void *hcpu)
{
Expand Down Expand Up @@ -621,6 +622,7 @@ static int padata_cpu_callback(struct notifier_block *nfb,

return NOTIFY_OK;
}
#endif

/*
* padata_alloc - allocate and initialize a padata instance
Expand All @@ -631,7 +633,6 @@ static int padata_cpu_callback(struct notifier_block *nfb,
struct padata_instance *padata_alloc(const struct cpumask *cpumask,
struct workqueue_struct *wq)
{
int err;
struct padata_instance *pinst;
struct parallel_data *pd;

Expand All @@ -654,18 +655,16 @@ struct padata_instance *padata_alloc(const struct cpumask *cpumask,

pinst->flags = 0;

#ifdef CONFIG_HOTPLUG_CPU
pinst->cpu_notifier.notifier_call = padata_cpu_callback;
pinst->cpu_notifier.priority = 0;
err = register_hotcpu_notifier(&pinst->cpu_notifier);
if (err)
goto err_free_cpumask;
register_hotcpu_notifier(&pinst->cpu_notifier);
#endif

mutex_init(&pinst->lock);

return pinst;

err_free_cpumask:
free_cpumask_var(pinst->cpumask);
err_free_pd:
padata_free_pd(pd);
err_free_inst:
Expand All @@ -689,7 +688,9 @@ void padata_free(struct padata_instance *pinst)
while (atomic_read(&pinst->pd->refcnt) != 0)
yield();

#ifdef CONFIG_HOTPLUG_CPU
unregister_hotcpu_notifier(&pinst->cpu_notifier);
#endif
padata_free_pd(pinst->pd);
free_cpumask_var(pinst->cpumask);
kfree(pinst);
Expand Down

0 comments on commit e2cb2f1

Please sign in to comment.