Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 314014
b: refs/heads/master
c: ebf348f
h: refs/heads/master
v: v3
  • Loading branch information
Johannes Berg authored and John W. Linville committed Jun 6, 2012
1 parent 730d385 commit e2daeb1
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 8 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: ccaf8c32d5ed08bfb4c45492f8f1c145fd45f4e8
refs/heads/master: ebf348fcd088e3ffc6e76f6f349e27d30604865b
2 changes: 2 additions & 0 deletions trunk/include/linux/nl80211.h
Original file line number Diff line number Diff line change
Expand Up @@ -1522,6 +1522,8 @@ enum nl80211_attrs {
#define NL80211_MAX_NR_CIPHER_SUITES 5
#define NL80211_MAX_NR_AKM_SUITES 2

#define NL80211_MIN_REMAIN_ON_CHANNEL_TIME 10

/**
* enum nl80211_iftype - (virtual) interface types
*
Expand Down
23 changes: 16 additions & 7 deletions trunk/net/wireless/nl80211.c
Original file line number Diff line number Diff line change
Expand Up @@ -5545,18 +5545,18 @@ static int nl80211_remain_on_channel(struct sk_buff *skb,

duration = nla_get_u32(info->attrs[NL80211_ATTR_DURATION]);

if (!rdev->ops->remain_on_channel ||
!(rdev->wiphy.flags & WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL))
return -EOPNOTSUPP;

/*
* We should be on that channel for at least one jiffie,
* and more than 5 seconds seems excessive.
* We should be on that channel for at least a minimum amount of
* time (10ms) but no longer than the driver supports.
*/
if (!duration || !msecs_to_jiffies(duration) ||
if (duration < NL80211_MIN_REMAIN_ON_CHANNEL_TIME ||
duration > rdev->wiphy.max_remain_on_channel_duration)
return -EINVAL;

if (!rdev->ops->remain_on_channel ||
!(rdev->wiphy.flags & WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL))
return -EOPNOTSUPP;

if (info->attrs[NL80211_ATTR_WIPHY_CHANNEL_TYPE] &&
!nl80211_valid_channel_type(info, &channel_type))
return -EINVAL;
Expand Down Expand Up @@ -5827,6 +5827,15 @@ static int nl80211_tx_mgmt(struct sk_buff *skb, struct genl_info *info)
if (!(rdev->wiphy.flags & WIPHY_FLAG_OFFCHAN_TX))
return -EINVAL;
wait = nla_get_u32(info->attrs[NL80211_ATTR_DURATION]);

/*
* We should wait on the channel for at least a minimum amount
* of time (10ms) but no longer than the driver supports.
*/
if (wait < NL80211_MIN_REMAIN_ON_CHANNEL_TIME ||
wait > rdev->wiphy.max_remain_on_channel_duration)
return -EINVAL;

}

if (info->attrs[NL80211_ATTR_WIPHY_CHANNEL_TYPE]) {
Expand Down

0 comments on commit e2daeb1

Please sign in to comment.