Skip to content

Commit

Permalink
ARM: OMAP: add includes for missing prototypes
Browse files Browse the repository at this point in the history
Several C files in arch/arm/mach-omap* and arch/arm/plat-omap declare
functions that are used by other files, but don't include the header
file where the prototype is declared.  This results in the following
warnings from sparse:

    arch/arm/mach-omap2/irq.c:114:5: warning: symbol 'omap_irq_pending' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:186:13: warning: symbol 'omap2_init_irq' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:191:13: warning: symbol 'omap3_init_irq' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:196:13: warning: symbol 'ti81xx_init_irq' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:233:39: warning: symbol 'omap2_intc_handle_irq' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:242:6: warning: symbol 'omap_intc_save_context' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:265:6: warning: symbol 'omap_intc_restore_context' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:291:6: warning: symbol 'omap3_intc_suspend' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:297:6: warning: symbol 'omap3_intc_prepare_idle' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:306:6: warning: symbol 'omap3_intc_resume_idle' was not declared. Should it be static?
    arch/arm/mach-omap2/irq.c:312:39: warning: symbol 'omap3_intc_handle_irq' was not declared. Should it be static?
    arch/arm/mach-omap2/omap-secure.c:59:12: warning: symbol 'omap_secure_ram_reserve_memblock' was not declared. Should it be static?
    arch/arm/mach-omap2/board-zoom-display.c:133:13: warning: symbol 'zoom_display_init' was not declared. Should it be static?
    arch/arm/plat-omap/common.c:73:13: warning: symbol 'omap_init_consistent_dma_size' was not declared. Should it be static?
    arch/arm/mach-omap1/irq.c:61:5: warning: symbol 'omap_irq_flags' was not declared. Should it be static?
    arch/arm/mach-omap1/irq.c:179:13: warning: symbol 'omap1_init_irq' was not declared. Should it be static?
    arch/arm/mach-omap1/reset.c:11:6: warning: symbol 'omap1_restart' was not declared. Should it be static?

Fix by including the appropriate header files.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Senthilvadivu Guruswamy <svadivu@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
  • Loading branch information
Paul Walmsley committed Apr 13, 2012
1 parent 8c3d453 commit e2ed89f
Show file tree
Hide file tree
Showing 13 changed files with 19 additions and 5 deletions.
5 changes: 4 additions & 1 deletion arch/arm/mach-omap1/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,11 @@ void omap1_init_early(void);
void omap1_init_irq(void);
void omap1_restart(char, const char *);

extern void __init omap_check_revision(void);

extern struct sys_timer omap1_timer;
extern bool omap_32k_timer_init(void);
extern void __init omap_init_consistent_dma_size(void);

extern u32 omap_irq_flags;

#endif /* __ARCH_ARM_MACH_OMAP1_COMMON_H */
2 changes: 2 additions & 0 deletions arch/arm/mach-omap1/id.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

#include <mach/hardware.h>

#include "common.h"

#define OMAP_DIE_ID_0 0xfffe1800
#define OMAP_DIE_ID_1 0xfffe1804
#define OMAP_PRODUCTION_ID_0 0xfffe2000
Expand Down
3 changes: 1 addition & 2 deletions arch/arm/mach-omap1/io.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@

#include <plat/mux.h>
#include <plat/tc.h>
#include <plat/dma.h>

#include "iomap.h"
#include "common.h"
#include "clock.h"

extern void omap_check_revision(void);

/*
* The machine specific code may provide the extra mapping besides the
* default mapping provided here.
Expand Down
2 changes: 2 additions & 0 deletions arch/arm/mach-omap1/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@

#include <mach/hardware.h>

#include "common.h"

#define IRQ_BANK(irq) ((irq) >> 5)
#define IRQ_BIT(irq) ((irq) & 0x1f)

Expand Down
2 changes: 2 additions & 0 deletions arch/arm/mach-omap1/reset.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

#include <mach/hardware.h>

#include "common.h"

void omap1_restart(char mode, const char *cmd)
{
/*
Expand Down
1 change: 1 addition & 0 deletions arch/arm/mach-omap2/board-zoom-display.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <linux/spi/spi.h>
#include <plat/mcspi.h>
#include <video/omapdss.h>
#include <mach/board-zoom.h>

#define LCD_PANEL_RESET_GPIO_PROD 96
#define LCD_PANEL_RESET_GPIO_PILOT 55
Expand Down
2 changes: 0 additions & 2 deletions arch/arm/mach-omap2/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ void omap4_map_io(void);
void ti81xx_map_io(void);
void omap_barriers_init(void);

extern void __init omap_init_consistent_dma_size(void);

/**
* omap_test_timeout - busy-loop, testing a condition
* @cond: condition to test until it evaluates to true
Expand Down
1 change: 1 addition & 0 deletions arch/arm/mach-omap2/io.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <plat/omap-pm.h>
#include <plat/omap_hwmod.h>
#include <plat/multi.h>
#include <plat/dma.h>

#include "iomap.h"
#include "voltage.h"
Expand Down
1 change: 1 addition & 0 deletions arch/arm/mach-omap2/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <mach/hardware.h>

#include "iomap.h"
#include "common.h"

/* selected INTC register offsets */

Expand Down
1 change: 1 addition & 0 deletions arch/arm/mach-omap2/omap-secure.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include <asm/cacheflush.h>
#include <asm/memblock.h>

#include <plat/omap-secure.h>
#include <mach/omap-secure.h>

static phys_addr_t omap_secure_memblock_base;
Expand Down
1 change: 1 addition & 0 deletions arch/arm/plat-omap/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <plat/board.h>
#include <plat/vram.h>
#include <plat/dsp.h>
#include <plat/dma.h>

#include <plat/omap-secure.h>

Expand Down
2 changes: 2 additions & 0 deletions arch/arm/plat-omap/include/plat/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@

extern int __init omap_init_clocksource_32k(void);

extern void __init omap_check_revision(void);

extern void omap_reserve(void);
extern int omap_dss_reset(struct omap_hwmod *);

Expand Down
1 change: 1 addition & 0 deletions arch/arm/plat-omap/include/plat/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ struct omap_system_dma_plat_info {
u32 (*dma_read)(int reg, int lch);
};

extern void __init omap_init_consistent_dma_size(void);
extern void omap_set_dma_priority(int lch, int dst_port, int priority);
extern int omap_request_dma(int dev_id, const char *dev_name,
void (*callback)(int lch, u16 ch_status, void *data),
Expand Down

0 comments on commit e2ed89f

Please sign in to comment.