Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 310247
b: refs/heads/master
c: 3c58264
h: refs/heads/master
i:
  310245: 77f4a97
  310243: 2593b5c
  310239: 11219bc
v: v3
  • Loading branch information
Thomas Abraham authored and Florian Tobias Schandinat committed Apr 9, 2012
1 parent 45d3532 commit e30e974
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 23 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: a4196febbe75e2cc8fcb7af6460d2c3ef208d66c
refs/heads/master: 3c582647a9f84affd5c86e89d548157c62f8d9ca
2 changes: 0 additions & 2 deletions trunk/arch/arm/plat-samsung/include/plat/fb.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ struct s3c_fb_platdata {
struct s3c_fb_pd_win *win[S3C_FB_MAX_WIN];
struct fb_videomode *vtiming;

u32 default_win;

u32 vidcon0;
u32 vidcon1;
};
Expand Down
25 changes: 5 additions & 20 deletions trunk/drivers/video/s3c-fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ static int s3c_fb_set_par(struct fb_info *info)
/* disable the window whilst we update it */
writel(0, regs + WINCON(win_no));

if (win_no == sfb->pdata->default_win)
if (!sfb->output_on)
s3c_fb_enable(sfb, 1);

/* write the buffer address */
Expand Down Expand Up @@ -799,6 +799,7 @@ static int s3c_fb_blank(int blank_mode, struct fb_info *info)
struct s3c_fb *sfb = win->parent;
unsigned int index = win->index;
u32 wincon;
u32 output_on = sfb->output_on;

dev_dbg(sfb->dev, "blank mode %d\n", blank_mode);

Expand Down Expand Up @@ -837,34 +838,18 @@ static int s3c_fb_blank(int blank_mode, struct fb_info *info)

shadow_protect_win(win, 1);
writel(wincon, sfb->regs + sfb->variant.wincon + (index * 4));
shadow_protect_win(win, 0);

/* Check the enabled state to see if we need to be running the
* main LCD interface, as if there are no active windows then
* it is highly likely that we also do not need to output
* anything.
*/

/* We could do something like the following code, but the current
* system of using framebuffer events means that we cannot make
* the distinction between just window 0 being inactive and all
* the windows being down.
*
* s3c_fb_enable(sfb, sfb->enabled ? 1 : 0);
*/

/* we're stuck with this until we can do something about overriding
* the power control using the blanking event for a single fb.
*/
if (index == sfb->pdata->default_win) {
shadow_protect_win(win, 1);
s3c_fb_enable(sfb, blank_mode != FB_BLANK_POWERDOWN ? 1 : 0);
shadow_protect_win(win, 0);
}
s3c_fb_enable(sfb, sfb->enabled ? 1 : 0);
shadow_protect_win(win, 0);

pm_runtime_put_sync(sfb->dev);

return 0;
return output_on == sfb->output_on;
}

/**
Expand Down

0 comments on commit e30e974

Please sign in to comment.