Skip to content

Commit

Permalink
Char: isicom, del_timer at exit
Browse files Browse the repository at this point in the history
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jiri Slaby authored and Linus Torvalds committed Jul 17, 2007
1 parent 5b21f9d commit e327325
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions drivers/char/isicom.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,6 @@ static struct pci_driver isicom_driver = {
static int prev_card = 3; /* start servicing isi_card[0] */
static struct tty_driver *isicom_normal;

static DECLARE_COMPLETION(isi_timerdone);
static char re_schedule = 1;

static void isicom_tx(unsigned long _data);
static void isicom_start(struct tty_struct *tty);

Expand Down Expand Up @@ -502,11 +499,6 @@ static void isicom_tx(unsigned long _data)
spin_unlock_irqrestore(&isi_card[card].card_lock, flags);
/* schedule another tx for hopefully in about 10ms */
sched_again:
if (!re_schedule) {
complete(&isi_timerdone);
return;
}

mod_timer(&tx, jiffies + msecs_to_jiffies(10));
}

Expand Down Expand Up @@ -1890,9 +1882,7 @@ static int __init isicom_init(void)

static void __exit isicom_exit(void)
{
re_schedule = 0;

wait_for_completion_timeout(&isi_timerdone, HZ);
del_timer_sync(&tx);

pci_unregister_driver(&isicom_driver);
tty_unregister_driver(isicom_normal);
Expand Down

0 comments on commit e327325

Please sign in to comment.