Skip to content

Commit

Permalink
drm/nouveau: fix missing spin_unlock in failure path
Browse files Browse the repository at this point in the history
Found by sparse.

Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
Signed-off-by: Francisco Jerez <currojerez@riseup.net>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
  • Loading branch information
Luca Barbieri authored and Ben Skeggs committed Feb 25, 2010
1 parent 761c5a6 commit e32b2c8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/nouveau/nouveau_gem.c
Original file line number Diff line number Diff line change
Expand Up @@ -558,11 +558,11 @@ nouveau_gem_pushbuf_reloc_apply(struct drm_device *dev,

spin_lock(&nvbo->bo.lock);
ret = ttm_bo_wait(&nvbo->bo, false, false, false);
spin_unlock(&nvbo->bo.lock);
if (ret) {
NV_ERROR(dev, "reloc wait_idle failed: %d\n", ret);
break;
}
spin_unlock(&nvbo->bo.lock);

nouveau_bo_wr32(nvbo, r->reloc_bo_offset >> 2, data);
}
Expand Down

0 comments on commit e32b2c8

Please sign in to comment.