Skip to content

Commit

Permalink
V4L/DVB (3405): Fixes tvp5150a/am1 detection.
Browse files Browse the repository at this point in the history
- Tvp5150 type were determined by a secondary register instead of
  using ROM code.
- tvp5150am1 have ROM=4.0, while tvp5150a have ROM=3.33 (decimal).
  All other ROM versions are reported as unknown tvp5150.
- Except for reporting, current code doesn't enable any special feature
  for tvp5150am1 or tvp5150a. Code should work for both models (but were
  tested only for tvp5150am1).

Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Mauro Carvalho Chehab authored and Mauro Carvalho Chehab committed Jan 23, 2006
1 parent 337208d commit e36eaa7
Showing 1 changed file with 12 additions and 9 deletions.
21 changes: 12 additions & 9 deletions drivers/media/video/tvp5150.c
Original file line number Diff line number Diff line change
Expand Up @@ -746,24 +746,27 @@ static int tvp5150_set_std(struct i2c_client *c, v4l2_std_id std)

static inline void tvp5150_reset(struct i2c_client *c)
{
u8 type, ver_656, msb_id, lsb_id, msb_rom, lsb_rom;
u8 msb_id, lsb_id, msb_rom, lsb_rom;
struct tvp5150 *decoder = i2c_get_clientdata(c);

type=tvp5150_read(c,TVP5150_AUTOSW_MSK);
msb_id=tvp5150_read(c,TVP5150_MSB_DEV_ID);
lsb_id=tvp5150_read(c,TVP5150_LSB_DEV_ID);
msb_rom=tvp5150_read(c,TVP5150_ROM_MAJOR_VER);
lsb_rom=tvp5150_read(c,TVP5150_ROM_MINOR_VER);

if (type==0xdc) {
ver_656=tvp5150_read(c,TVP5150_REV_SELECT);
tvp5150_info("tvp%02x%02xam1 detected 656 version is %d.\n",msb_id, lsb_id,ver_656);
} else if (type==0xfc) {
tvp5150_info("tvp%02x%02xa detected.\n",msb_id, lsb_id);
if ((msb_rom==4)&&(lsb_rom==0)) { /* Is TVP5150AM1 */
tvp5150_info("tvp%02x%02xam1 detected.\n",msb_id, lsb_id);

/* ITU-T BT.656.4 timing */
tvp5150_write(c,TVP5150_REV_SELECT,0);
} else {
tvp5150_info("unknown tvp%02x%02x chip detected(%d).\n",msb_id,lsb_id,type);
if ((msb_rom==3)||(lsb_rom==0x21)) { /* Is TVP5150A */
tvp5150_info("tvp%02x%02xa detected.\n",msb_id, lsb_id);
} else {
tvp5150_info("*** unknown tvp%02x%02x chip detected.\n",msb_id,lsb_id);
tvp5150_info("*** Rom ver is %d.%d\n",msb_rom,lsb_rom);
}
}
tvp5150_info("Rom ver is %d.%d\n",msb_rom,lsb_rom);

/* Initializes TVP5150 to its default values */
tvp5150_write_inittab(c, tvp5150_init_default);
Expand Down

0 comments on commit e36eaa7

Please sign in to comment.