Skip to content

Commit

Permalink
ext4: no need to add inode to orphan list during hole punch
Browse files Browse the repository at this point in the history
While performing punch hole for an inode, i_disksize is not changed.
So, there is no need to add the inode to orphan list.

Signed-off-by: Ashish Sangwan <ashish.sangwan2@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Acked-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Ashish Sangwan authored and Theodore Ts'o committed Aug 19, 2012
1 parent eeecef0 commit e3d2e43
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions fs/ext4/extents.c
Original file line number Diff line number Diff line change
Expand Up @@ -4860,9 +4860,6 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length)
if (IS_ERR(handle))
return PTR_ERR(handle);

err = ext4_orphan_add(handle, inode);
if (err)
goto out;

/*
* Now we need to zero out the non-page-aligned data in the
Expand Down Expand Up @@ -4948,7 +4945,6 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length)
up_write(&EXT4_I(inode)->i_data_sem);

out:
ext4_orphan_del(handle, inode);
inode->i_mtime = inode->i_ctime = ext4_current_time(inode);
ext4_mark_inode_dirty(handle, inode);
ext4_journal_stop(handle);
Expand Down

0 comments on commit e3d2e43

Please sign in to comment.