Skip to content

Commit

Permalink
Mark ptrace_{traceme,attach,detach} static
Browse files Browse the repository at this point in the history
They are only used inside kernel/ptrace.c, and have been for a long
time.  We don't want to go back to the bad-old-days when architectures
did things on their own, so make them static and private.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Linus Torvalds committed Mar 4, 2011
1 parent b65a0e0 commit e3e89cc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 0 additions & 3 deletions include/linux/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,8 @@

extern long arch_ptrace(struct task_struct *child, long request,
unsigned long addr, unsigned long data);
extern int ptrace_traceme(void);
extern int ptrace_readdata(struct task_struct *tsk, unsigned long src, char __user *dst, int len);
extern int ptrace_writedata(struct task_struct *tsk, char __user *src, unsigned long dst, int len);
extern int ptrace_attach(struct task_struct *tsk);
extern int ptrace_detach(struct task_struct *, unsigned int);
extern void ptrace_disable(struct task_struct *);
extern int ptrace_check_attach(struct task_struct *task, int kill);
extern int ptrace_request(struct task_struct *child, long request,
Expand Down
6 changes: 3 additions & 3 deletions kernel/ptrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ bool ptrace_may_access(struct task_struct *task, unsigned int mode)
return !err;
}

int ptrace_attach(struct task_struct *task)
static int ptrace_attach(struct task_struct *task)
{
int retval;

Expand Down Expand Up @@ -219,7 +219,7 @@ int ptrace_attach(struct task_struct *task)
* Performs checks and sets PT_PTRACED.
* Should be used by all ptrace implementations for PTRACE_TRACEME.
*/
int ptrace_traceme(void)
static int ptrace_traceme(void)
{
int ret = -EPERM;

Expand Down Expand Up @@ -293,7 +293,7 @@ static bool __ptrace_detach(struct task_struct *tracer, struct task_struct *p)
return false;
}

int ptrace_detach(struct task_struct *child, unsigned int data)
static int ptrace_detach(struct task_struct *child, unsigned int data)
{
bool dead = false;

Expand Down

0 comments on commit e3e89cc

Please sign in to comment.