Skip to content

Commit

Permalink
perf tools: Use evsel->attr.sample_type instead of session->sample_type
Browse files Browse the repository at this point in the history
Eventually session->sample_type will go away as we want to support
multiple sample types per session, so use it from the evsel which is a
step in that direction.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-0vwdpjcwbjezw459lw5n3ew1@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Nov 28, 2011
1 parent 246d4ce commit e3f4260
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
5 changes: 3 additions & 2 deletions tools/perf/builtin-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#include "util/util.h"
#include "util/cache.h"
#include "util/evsel.h"
#include "util/symbol.h"
#include "util/thread.h"
#include "util/header.h"
Expand Down Expand Up @@ -1603,12 +1604,12 @@ static void process_raw_event(union perf_event *raw_event __used,

static int process_sample_event(union perf_event *event,
struct perf_sample *sample,
struct perf_evsel *evsel __used,
struct perf_evsel *evsel,
struct perf_session *session)
{
struct thread *thread;

if (!(session->sample_type & PERF_SAMPLE_RAW))
if (!(evsel->attr.sample_type & PERF_SAMPLE_RAW))
return 0;

thread = perf_session__findnew(session, sample->pid);
Expand Down
9 changes: 5 additions & 4 deletions tools/perf/builtin-timechart.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include "util/color.h"
#include <linux/list.h>
#include "util/cache.h"
#include "util/evsel.h"
#include <linux/rbtree.h>
#include "util/symbol.h"
#include "util/callchain.h"
Expand Down Expand Up @@ -488,20 +489,20 @@ static void sched_switch(int cpu, u64 timestamp, struct trace_entry *te)

static int process_sample_event(union perf_event *event __used,
struct perf_sample *sample,
struct perf_evsel *evsel __used,
struct perf_session *session)
struct perf_evsel *evsel,
struct perf_session *session __used)
{
struct trace_entry *te;

if (session->sample_type & PERF_SAMPLE_TIME) {
if (evsel->attr.sample_type & PERF_SAMPLE_TIME) {
if (!first_time || first_time > sample->time)
first_time = sample->time;
if (last_time < sample->time)
last_time = sample->time;
}

te = (void *)sample->raw_data;
if (session->sample_type & PERF_SAMPLE_RAW && sample->raw_size > 0) {
if ((evsel->attr.sample_type & PERF_SAMPLE_RAW) && sample->raw_size > 0) {
char *event_str;
#ifdef SUPPORT_OLD_POWER_EVENTS
struct power_entry_old *peo;
Expand Down

0 comments on commit e3f4260

Please sign in to comment.