Skip to content

Commit

Permalink
[PATCH] ALPS: fix enabling hardware tapping
Browse files Browse the repository at this point in the history
It looks like logic for enabling hardware tapping in ALPS driver was
inverted and we enable it only if it was already enabled by BIOS or
firmware.

I have a confirmation from one user that the patch below fixes the problem
for him and it might be beneficial if we could get it into 2.6.12.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Dmitry Torokhov authored and Linus Torvalds committed Jun 16, 2005
1 parent 5db9285 commit e41fb09
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/input/mouse/alps.c
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ static int alps_reconnect(struct psmouse *psmouse)
if (alps_get_status(psmouse, param))
return -1;

if (param[0] & 0x04)
if (!(param[0] & 0x04))
alps_tap_mode(psmouse, 1);

if (alps_absolute_mode(psmouse)) {
Expand Down

0 comments on commit e41fb09

Please sign in to comment.