Skip to content

Commit

Permalink
hso: remove hso_free_device()
Browse files Browse the repository at this point in the history
There is really no need for function just doing simple kfree()

Signed-off-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
Cc: Denis Joseph Barrow <D.Barow@option.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Paulius Zaleckas authored and David S. Miller committed Feb 27, 2009
1 parent a6f26e4 commit e44578e
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions drivers/net/usb/hso.c
Original file line number Diff line number Diff line change
Expand Up @@ -2363,12 +2363,6 @@ static int hso_serial_common_create(struct hso_serial *serial, int num_urbs,
return -1;
}

/* Frees a general hso device */
static void hso_free_device(struct hso_device *hso_dev)
{
kfree(hso_dev);
}

/* Creates a general hso device */
static struct hso_device *hso_create_device(struct usb_interface *intf,
int port_spec)
Expand Down Expand Up @@ -2431,7 +2425,7 @@ static void hso_free_net_device(struct hso_device *hso_dev)
free_netdev(hso_net->net);
}

hso_free_device(hso_dev);
kfree(hso_dev);
}

/* initialize the network interface */
Expand Down Expand Up @@ -2645,7 +2639,7 @@ static void hso_free_serial_device(struct hso_device *hso_dev)
}
hso_free_tiomget(serial);
kfree(serial);
hso_free_device(hso_dev);
kfree(hso_dev);
}

/* Creates a bulk AT channel */
Expand Down Expand Up @@ -2726,7 +2720,7 @@ static struct hso_device *hso_create_bulk_serial_device(
exit:
hso_free_tiomget(serial);
kfree(serial);
hso_free_device(hso_dev);
kfree(hso_dev);
return NULL;
}

Expand Down Expand Up @@ -2785,7 +2779,7 @@ struct hso_device *hso_create_mux_serial_device(struct usb_interface *interface,
kfree(serial);
}
if (hso_dev)
hso_free_device(hso_dev);
kfree(hso_dev);
return NULL;

}
Expand Down

0 comments on commit e44578e

Please sign in to comment.