Skip to content

Commit

Permalink
spi/orion: Drop unnecessary null test
Browse files Browse the repository at this point in the history
list_for_each_entry binds its first argument to a non-null value, and thus
any null test on the value of that argument is superfluous.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
iterator I;
expression x,E;
@@

I(x,...) { <...
- (x != NULL) &&
  E
  ...> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Julia Lawall authored and Grant Likely committed Sep 29, 2010
1 parent 079a176 commit e447d35
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/spi/orion_spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ static int orion_spi_transfer(struct spi_device *spi, struct spi_message *m)
goto msg_rejected;
}

if ((t != NULL) && t->bits_per_word)
if (t->bits_per_word)
bits_per_word = t->bits_per_word;

if ((bits_per_word != 8) && (bits_per_word != 16)) {
Expand All @@ -415,7 +415,7 @@ static int orion_spi_transfer(struct spi_device *spi, struct spi_message *m)
goto msg_rejected;
}
/*make sure buffer length is even when working in 16 bit mode*/
if ((t != NULL) && (t->bits_per_word == 16) && (t->len & 1)) {
if ((t->bits_per_word == 16) && (t->len & 1)) {
dev_err(&spi->dev,
"message rejected : "
"odd data length (%d) while in 16 bit mode\n",
Expand Down

0 comments on commit e447d35

Please sign in to comment.