Skip to content

Commit

Permalink
Input: intel-mid-touch - remove pointless checking for variable 'found'
Browse files Browse the repository at this point in the history
The implementation does break from the for loop after we assign 'i' to
variable 'found'.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Axel Lin authored and Dmitry Torokhov committed Jul 19, 2011
1 parent dc3e824 commit e449edb
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions drivers/input/touchscreen/intel-mid-touch.c
Original file line number Diff line number Diff line change
Expand Up @@ -448,15 +448,11 @@ static int __devinit mrstouch_read_pmic_id(uint *vendor, uint *rev)
*/
static int __devinit mrstouch_chan_parse(struct mrstouch_dev *tsdev)
{
int err, i, found;
int found = 0;
int err, i;
u8 r8;

found = -1;

for (i = 0; i < MRSTOUCH_MAX_CHANNELS; i++) {
if (found >= 0)
break;

err = intel_scu_ipc_ioread8(PMICADDR0 + i, &r8);
if (err)
return err;
Expand All @@ -466,16 +462,15 @@ static int __devinit mrstouch_chan_parse(struct mrstouch_dev *tsdev)
break;
}
}
if (found < 0)
return 0;

if (tsdev->vendor == PMIC_VENDOR_FS) {
if (found && found > (MRSTOUCH_MAX_CHANNELS - 18))
if (found > MRSTOUCH_MAX_CHANNELS - 18)
return -ENOSPC;
} else {
if (found && found > (MRSTOUCH_MAX_CHANNELS - 4))
if (found > MRSTOUCH_MAX_CHANNELS - 4)
return -ENOSPC;
}

return found;
}

Expand Down

0 comments on commit e449edb

Please sign in to comment.