Skip to content

Commit

Permalink
drm/radeon: Don't unreserve twice on failure to validate.
Browse files Browse the repository at this point in the history
This is done later in radeon_object_list_unvalidate(). Doing it twice triggers
a BUG in TTM, rendering X on KMS unusable until reboot.

Signed-off-by: Michel Dänzer <daenzer@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
  • Loading branch information
Michel Dänzer authored and Dave Airlie committed Jul 29, 2009
1 parent c93bb85 commit e46074e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/gpu/drm/radeon/radeon_object.c
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,6 @@ int radeon_object_list_validate(struct list_head *head, void *fence)
robj->tobj.proposed_placement,
true, false);
if (unlikely(r)) {
radeon_object_list_unreserve(head);
DRM_ERROR("radeon: failed to validate.\n");
return r;
}
Expand Down

0 comments on commit e46074e

Please sign in to comment.