Skip to content

Commit

Permalink
mfd: Remove incorrect wm8350 kfree
Browse files Browse the repository at this point in the history
The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Rabin Vincent <rabin@rab.in>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Rabin Vincent authored and Samuel Ortiz committed May 27, 2010
1 parent fffba64 commit e47a3bb
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/mfd/wm8350-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,8 @@ static int wm8350_i2c_probe(struct i2c_client *i2c,
int ret = 0;

wm8350 = kzalloc(sizeof(struct wm8350), GFP_KERNEL);
if (wm8350 == NULL) {
kfree(i2c);
if (wm8350 == NULL)
return -ENOMEM;
}

i2c_set_clientdata(i2c, wm8350);
wm8350->dev = &i2c->dev;
Expand Down

0 comments on commit e47a3bb

Please sign in to comment.