Skip to content

Commit

Permalink
powerpc: Don't silently handle machine checks from userspace
Browse files Browse the repository at this point in the history
If a machine check comes from userspace we send a SIGBUS to the task and
fail to printk anything.

If we are taking machine checks due to bad hardware we want to know about
it right away. Furthermore if we don't complain loudly then it will look
a lot like a bug in the userspace application, potentially causing a lot
of confusion.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
  • Loading branch information
Anton Blanchard authored and Benjamin Herrenschmidt committed Jan 21, 2011
1 parent dfb5509 commit e49b1fa
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions arch/powerpc/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -626,11 +626,6 @@ void machine_check_exception(struct pt_regs *regs)
if (recover > 0)
return;

if (user_mode(regs)) {
_exception(SIGBUS, regs, BUS_ADRERR, regs->nip);
return;
}

#if defined(CONFIG_8xx) && defined(CONFIG_PCI)
/* the qspan pci read routines can cause machine checks -- Cort
*
Expand Down

0 comments on commit e49b1fa

Please sign in to comment.