Skip to content

Commit

Permalink
RDS/IB: add _to_node() macros for numa and use {k,v}malloc_node()
Browse files Browse the repository at this point in the history
Allocate send/recv rings in memory that is node-local to the HCA.
This significantly helps performance.

Signed-off-by: Andy Grover <andy.grover@oracle.com>
  • Loading branch information
Andy Grover committed Sep 9, 2010
1 parent 4a81802 commit e4c52c9
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
2 changes: 1 addition & 1 deletion net/rds/ib.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ void rds_ib_add_one(struct ib_device *device)
goto free_attr;
}

rds_ibdev = kmalloc(sizeof *rds_ibdev, GFP_KERNEL);
rds_ibdev = kmalloc_node(sizeof *rds_ibdev, GFP_KERNEL, ibdev_to_node(device));
if (!rds_ibdev)
goto free_attr;

Expand Down
6 changes: 6 additions & 0 deletions net/rds/ib.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

#include <rdma/ib_verbs.h>
#include <rdma/rdma_cm.h>
#include <linux/pci.h>
#include <linux/slab.h>
#include "rds.h"
#include "rdma_transport.h"

Expand Down Expand Up @@ -167,6 +169,10 @@ struct rds_ib_device {
spinlock_t spinlock; /* protect the above */
};

#define pcidev_to_node(pcidev) pcibus_to_node(pcidev->bus)
#define ibdev_to_node(ibdev) pcidev_to_node(to_pci_dev(ibdev->dma_device))
#define rdsibdev_to_node(rdsibdev) ibdev_to_node(rdsibdev->dev)

/* bits for i_ack_flags */
#define IB_ACK_IN_FLIGHT 0
#define IB_ACK_REQUESTED 1
Expand Down
6 changes: 4 additions & 2 deletions net/rds/ib_cm.c
Original file line number Diff line number Diff line change
Expand Up @@ -347,15 +347,17 @@ static int rds_ib_setup_qp(struct rds_connection *conn)
goto out;
}

ic->i_sends = vmalloc(ic->i_send_ring.w_nr * sizeof(struct rds_ib_send_work));
ic->i_sends = vmalloc_node(ic->i_send_ring.w_nr * sizeof(struct rds_ib_send_work),
ibdev_to_node(dev));
if (!ic->i_sends) {
ret = -ENOMEM;
rdsdebug("send allocation failed\n");
goto out;
}
memset(ic->i_sends, 0, ic->i_send_ring.w_nr * sizeof(struct rds_ib_send_work));

ic->i_recvs = vmalloc(ic->i_recv_ring.w_nr * sizeof(struct rds_ib_recv_work));
ic->i_recvs = vmalloc_node(ic->i_recv_ring.w_nr * sizeof(struct rds_ib_recv_work),
ibdev_to_node(dev));
if (!ic->i_recvs) {
ret = -ENOMEM;
rdsdebug("recv allocation failed\n");
Expand Down
5 changes: 3 additions & 2 deletions net/rds/ib_rdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ static struct rds_ib_mr *rds_ib_alloc_fmr(struct rds_ib_device *rds_ibdev)
rds_ib_flush_mr_pool(pool, 0);
}

ibmr = kzalloc(sizeof(*ibmr), GFP_KERNEL);
ibmr = kzalloc_node(sizeof(*ibmr), GFP_KERNEL, rdsibdev_to_node(rds_ibdev));
if (!ibmr) {
err = -ENOMEM;
goto out_no_cigar;
Expand Down Expand Up @@ -376,7 +376,8 @@ static int rds_ib_map_fmr(struct rds_ib_device *rds_ibdev, struct rds_ib_mr *ibm
if (page_cnt > fmr_message_size)
return -EINVAL;

dma_pages = kmalloc(sizeof(u64) * page_cnt, GFP_ATOMIC);
dma_pages = kmalloc_node(sizeof(u64) * page_cnt, GFP_ATOMIC,
rdsibdev_to_node(rds_ibdev));
if (!dma_pages)
return -ENOMEM;

Expand Down

0 comments on commit e4c52c9

Please sign in to comment.