Skip to content

Commit

Permalink
perf ui/gtk: Fix callchain display
Browse files Browse the repository at this point in the history
With current output field change, GTK browser cannot display callchain
information correctly since it couldn't determine where the symbol
column is.  This is a problem - just for now I changed to use the last
column since it'll work for most cases.

Also it has a same problem of the percentage as stdio code.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Arun Sharma <asharma@fb.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/r/1401335910-16832-25-git-send-email-namhyung@kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
  • Loading branch information
Namhyung Kim authored and Jiri Olsa committed Jun 1, 2014
1 parent 56772ad commit e4cf6f8
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion tools/perf/ui/gtk/hists.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,13 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists,
if (perf_hpp__should_skip(fmt))
continue;

/*
* XXX no way to determine where symcol column is..
* Just use last column for now.
*/
if (perf_hpp__is_sort_entry(fmt))
sym_col = col_idx;

fmt->header(fmt, &hpp, hists_to_evsel(hists));

gtk_tree_view_insert_column_with_attributes(GTK_TREE_VIEW(view),
Expand Down Expand Up @@ -253,7 +260,8 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists,

if (symbol_conf.use_callchain && sort__has_sym) {
if (callchain_param.mode == CHAIN_GRAPH_REL)
total = h->stat.period;
total = symbol_conf.cumulate_callchain ?
h->stat_acc->period : h->stat.period;

perf_gtk__add_callchain(&h->sorted_chain, store, &iter,
sym_col, total);
Expand Down

0 comments on commit e4cf6f8

Please sign in to comment.