Skip to content

Commit

Permalink
powerpc/mpc5200: Bestcomm fixes to ATA support
Browse files Browse the repository at this point in the history
1) ata.h has dst_pa in the wrong place (needs to match what the BestComm
   task microcode in bcom_ata_task.c expects); fix it.

2) The BestComm ATA task priority was changed to maximum in bestcomm_priv.h;
   this fixes a deadlock issue experienced with heavy DMA occurring on
   both the ATA and Ethernet BestComm tasks, e.g. when downloading a large
   file over a LAN to disk.

Signed-off-by: Tim Yamin <plasm@roo.me.uk>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Tim Yamin authored and Grant Likely committed Dec 21, 2008
1 parent 6228824 commit e4efe3c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion arch/powerpc/sysdev/bestcomm/ata.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

struct bcom_ata_bd {
u32 status;
u32 dst_pa;
u32 src_pa;
u32 dst_pa;
};

extern struct bcom_task *
Expand Down
4 changes: 2 additions & 2 deletions arch/powerpc/sysdev/bestcomm/bestcomm_priv.h
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,8 @@ struct bcom_task_header {
#define BCOM_IPR_SCTMR_1 2
#define BCOM_IPR_FEC_RX 6
#define BCOM_IPR_FEC_TX 5
#define BCOM_IPR_ATA_RX 4
#define BCOM_IPR_ATA_TX 3
#define BCOM_IPR_ATA_RX 7
#define BCOM_IPR_ATA_TX 7
#define BCOM_IPR_SCPCI_RX 2
#define BCOM_IPR_SCPCI_TX 2
#define BCOM_IPR_PSC3_RX 2
Expand Down

0 comments on commit e4efe3c

Please sign in to comment.