Skip to content

Commit

Permalink
ide: mask interrupt in ide_config_drive_speed()
Browse files Browse the repository at this point in the history
Apparently, there is no sense in unmasking IRQ on the controller when you call
disable_irq_nosync() before doing this, set the nIEN bit afterwards, and then
unmask IRQ again after the command completion, hence 0 passed to SELECT_MASK()
before issuing the command in ide_config_drive_speed() is probably just a typo.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Sergei Shtylyov authored and Bartlomiej Zolnierkiewicz committed Oct 17, 2008
1 parent 79104c6 commit e5403bf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ide/ide-iops.c
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,7 @@ int ide_config_drive_speed(ide_drive_t *drive, u8 speed)

udelay(1);
SELECT_DRIVE(drive);
SELECT_MASK(drive, 0);
SELECT_MASK(drive, 1);
udelay(1);
tp_ops->set_irq(hwif, 0);

Expand Down

0 comments on commit e5403bf

Please sign in to comment.