Skip to content

Commit

Permalink
ALSA: hdsp - poll for iobox
Browse files Browse the repository at this point in the history
sleeping for 2 seconds before checking for the iobox is not enough
on some systems.
this patch increases the timeout, but polls the card during that
time. it thus speeds up the module loading when the card has already
been initialized, while being more robust on systems, which require
a higher timeout than the predefined 2 seconds.

Signed-off-by: Tim Blechmann <tim@klingt.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Tim Blechmann authored and Takashi Iwai committed Feb 23, 2009
1 parent 66a101d commit e588ed8
Showing 1 changed file with 25 additions and 4 deletions.
29 changes: 25 additions & 4 deletions sound/pci/rme9652/hdsp.c
Original file line number Diff line number Diff line change
Expand Up @@ -653,15 +653,36 @@ static unsigned int hdsp_read(struct hdsp *hdsp, int reg)

static int hdsp_check_for_iobox (struct hdsp *hdsp)
{

if (hdsp->io_type == H9652 || hdsp->io_type == H9632) return 0;
if (hdsp_read (hdsp, HDSP_statusRegister) & HDSP_ConfigError) {
snd_printk ("Hammerfall-DSP: no Digiface or Multiface connected!\n");
hdsp->state &= ~HDSP_FirmwareLoaded;
return -EIO;
}
return 0;
}

static int hdsp_wait_for_iobox(struct hdsp *hdsp, unsigned int loops,
unsigned int delay)
{
unsigned int i;

if (hdsp->io_type == H9652 || hdsp->io_type == H9632)
return 0;

for (i = 0; i != loops; ++i) {
if (hdsp_read(hdsp, HDSP_statusRegister) & HDSP_ConfigError)
msleep(delay);
else {
snd_printd("Hammerfall-DSP: iobox found after %ums!\n",
i * delay);
return 0;
}
}

snd_printk("Hammerfall-DSP: no Digiface or Multiface connected!\n");
hdsp->state &= ~HDSP_FirmwareLoaded;
return -EIO;
}

static int snd_hdsp_load_firmware_from_cache(struct hdsp *hdsp) {
Expand Down Expand Up @@ -5046,10 +5067,10 @@ static int __devinit snd_hdsp_create(struct snd_card *card,
return err;

if (!is_9652 && !is_9632) {
/* we wait 2 seconds to let freshly inserted cardbus cards do their hardware init */
ssleep(2);
/* we wait a maximum of 10 seconds to let freshly
* inserted cardbus cards do their hardware init */
err = hdsp_wait_for_iobox(hdsp, 1000, 10);

err = hdsp_check_for_iobox(hdsp);
if (err < 0)
return err;

Expand Down

0 comments on commit e588ed8

Please sign in to comment.