Skip to content

Commit

Permalink
Fix btrfs_fill_super to return -EINVAL when no FS found
Browse files Browse the repository at this point in the history
Signed-off-by: Chris Mason <chris.mason@oracle.com>
  • Loading branch information
Yan authored and Chris Mason committed Sep 25, 2008
1 parent 63b10fc commit e58ca02
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions fs/btrfs/disk-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -728,9 +728,8 @@ struct btrfs_root *open_ctree(struct super_block *sb,
struct btrfs_root *dev_root = kmalloc(sizeof(struct btrfs_root),
GFP_NOFS);
int ret;
int err = -EIO;
int err = -EINVAL;
struct btrfs_super_block *disk_super;

if (!extent_root || !tree_root || !fs_info) {
err = -ENOMEM;
goto fail;
Expand Down
4 changes: 2 additions & 2 deletions fs/btrfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,9 @@ static int btrfs_fill_super(struct super_block * sb,

tree_root = open_ctree(sb, fs_devices);

if (!tree_root || IS_ERR(tree_root)) {
if (IS_ERR(tree_root)) {
printk("btrfs: open_ctree failed\n");
return -EIO;
return PTR_ERR(tree_root);
}
sb->s_fs_info = tree_root;
disk_super = &tree_root->fs_info->super_copy;
Expand Down
2 changes: 1 addition & 1 deletion fs/btrfs/volumes.c
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ int btrfs_scan_one_device(const char *path, int flags, void *holder,
if (strncmp((char *)(&disk_super->magic), BTRFS_MAGIC,
sizeof(disk_super->magic))) {
printk("no btrfs found on %s\n", path);
ret = -ENOENT;
ret = -EINVAL;
goto error_brelse;
}
devid = le64_to_cpu(disk_super->dev_item.devid);
Expand Down

0 comments on commit e58ca02

Please sign in to comment.