Skip to content

Commit

Permalink
perf: Remove leftover useless options to record trace events from scr…
Browse files Browse the repository at this point in the history
…ipts

-f, -c 1, -R are now useless for trace events recording, moreover
-M is useless and event hurts.

Remove them from the documentation examples and from record scripts.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Tom Zanussi <tzanussi@gmail.com>
  • Loading branch information
Frederic Weisbecker committed Apr 30, 2010
1 parent bc4b473 commit e5a5f1f
Show file tree
Hide file tree
Showing 13 changed files with 17 additions and 21 deletions.
6 changes: 2 additions & 4 deletions tools/perf/Documentation/perf-trace-perl.txt
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,10 @@ available as calls back into the perf executable (see below).
As an example, the following perf record command can be used to record
all sched_wakeup events in the system:

# perf record -c 1 -f -a -M -R -e sched:sched_wakeup
# perf record -a -e sched:sched_wakeup

Traces meant to be processed using a script should be recorded with
the above options: -c 1 says to sample every event, -a to enable
system-wide collection, -M to multiplex the output, and -R to collect
raw samples.
the above option: -a to enable system-wide collection.

The format file for the sched_wakep event defines the following fields
(see /sys/kernel/debug/tracing/events/sched/sched_wakeup/format):
Expand Down
10 changes: 4 additions & 6 deletions tools/perf/Documentation/perf-trace-python.txt
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ don't care how it exited, so we'll use 'perf record' to record only
the sys_enter events:

----
# perf record -c 1 -f -a -M -R -e raw_syscalls:sys_enter
# perf record -a -e raw_syscalls:sys_enter

^C[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 56.545 MB perf.data (~2470503 samples) ]
Expand Down Expand Up @@ -359,7 +359,7 @@ your script:
# cat kernel-source/tools/perf/scripts/python/bin/syscall-counts-record

#!/bin/bash
perf record -c 1 -f -a -M -R -e raw_syscalls:sys_enter
perf record -a -e raw_syscalls:sys_enter
----

The 'report' script is also a shell script with the same base name as
Expand Down Expand Up @@ -449,12 +449,10 @@ available as calls back into the perf executable (see below).
As an example, the following perf record command can be used to record
all sched_wakeup events in the system:

# perf record -c 1 -f -a -M -R -e sched:sched_wakeup
# perf record -a -e sched:sched_wakeup

Traces meant to be processed using a script should be recorded with
the above options: -c 1 says to sample every event, -a to enable
system-wide collection, -M to multiplex the output, and -R to collect
raw samples.
the above option: -a to enable system-wide collection.

The format file for the sched_wakep event defines the following fields
(see /sys/kernel/debug/tracing/events/sched/sched_wakeup/format):
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/scripts/perl/bin/check-perf-trace-record
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e kmem:kmalloc -e irq:softirq_entry -e kmem:kfree
perf record -a -e kmem:kmalloc -e irq:softirq_entry -e kmem:kfree
2 changes: 1 addition & 1 deletion tools/perf/scripts/perl/bin/failed-syscalls-record
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e raw_syscalls:sys_exit $@
perf record -a -e raw_syscalls:sys_exit $@
2 changes: 1 addition & 1 deletion tools/perf/scripts/perl/bin/rw-by-file-record
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e syscalls:sys_enter_read -e syscalls:sys_enter_write $@
perf record -a -e syscalls:sys_enter_read -e syscalls:sys_enter_write $@

2 changes: 1 addition & 1 deletion tools/perf/scripts/perl/bin/rw-by-pid-record
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e syscalls:sys_enter_read -e syscalls:sys_exit_read -e syscalls:sys_enter_write -e syscalls:sys_exit_write $@
perf record -a -e syscalls:sys_enter_read -e syscalls:sys_exit_read -e syscalls:sys_enter_write -e syscalls:sys_exit_write $@
2 changes: 1 addition & 1 deletion tools/perf/scripts/perl/bin/rwtop-record
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e syscalls:sys_enter_read -e syscalls:sys_exit_read -e syscalls:sys_enter_write -e syscalls:sys_exit_write $@
perf record -a -e syscalls:sys_enter_read -e syscalls:sys_exit_read -e syscalls:sys_enter_write -e syscalls:sys_exit_write $@
2 changes: 1 addition & 1 deletion tools/perf/scripts/perl/bin/wakeup-latency-record
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e sched:sched_switch -e sched:sched_wakeup $@
perf record -a -e sched:sched_switch -e sched:sched_wakeup $@



Expand Down
2 changes: 1 addition & 1 deletion tools/perf/scripts/perl/bin/workqueue-stats-record
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e workqueue:workqueue_creation -e workqueue:workqueue_destruction -e workqueue:workqueue_execution -e workqueue:workqueue_insertion $@
perf record -a -e workqueue:workqueue_creation -e workqueue:workqueue_destruction -e workqueue:workqueue_execution -e workqueue:workqueue_insertion $@
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e raw_syscalls:sys_exit $@
perf record -a -e raw_syscalls:sys_exit $@
2 changes: 1 addition & 1 deletion tools/perf/scripts/python/bin/sctop-record
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e raw_syscalls:sys_enter $@
perf record -a -e raw_syscalls:sys_enter $@
2 changes: 1 addition & 1 deletion tools/perf/scripts/python/bin/syscall-counts-by-pid-record
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e raw_syscalls:sys_enter $@
perf record -a -e raw_syscalls:sys_enter $@
2 changes: 1 addition & 1 deletion tools/perf/scripts/python/bin/syscall-counts-record
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
perf record -c 1 -f -a -M -R -e raw_syscalls:sys_enter $@
perf record -a -e raw_syscalls:sys_enter $@

0 comments on commit e5a5f1f

Please sign in to comment.