Skip to content

Commit

Permalink
[media] xc5000: Don't wrap msleep()
Browse files Browse the repository at this point in the history
There's absolutely no reason to wrap msleep() call here.
Just rename all occurences of xc_wait() with msleep() and
remove the wrapper function.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
  • Loading branch information
Mauro Carvalho Chehab committed May 25, 2014
1 parent 859ae7f commit e5bf4a1
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions drivers/media/tuners/xc5000.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,6 @@ static int xc5000_readreg(struct xc5000_priv *priv, u16 reg, u16 *val)
return 0;
}

static void xc_wait(int wait_ms)
{
msleep(wait_ms);
}

static int xc5000_TunerReset(struct dvb_frontend *fe)
{
struct xc5000_priv *priv = fe->tuner_priv;
Expand Down Expand Up @@ -342,7 +337,7 @@ static int xc_write_reg(struct xc5000_priv *priv, u16 regAddr, u16 i2cData)
/* busy flag cleared */
break;
} else {
xc_wait(5); /* wait 5 ms */
msleep(5); /* wait 5 ms */
WatchDogTimer--;
}
}
Expand Down Expand Up @@ -374,7 +369,7 @@ static int xc_load_i2c_sequence(struct dvb_frontend *fe, const u8 *i2c_sequence)
return result;
} else if (len & 0x8000) {
/* WAIT command */
xc_wait(len & 0x7FFF);
msleep(len & 0x7FFF);
index += 2;
} else {
/* Send i2c data whilst ensuring individual transactions
Expand Down Expand Up @@ -571,7 +566,7 @@ static u16 WaitForLock(struct xc5000_priv *priv)
while ((lockState == 0) && (watchDogCount > 0)) {
xc_get_lock_status(priv, &lockState);
if (lockState != 1) {
xc_wait(5);
msleep(5);
watchDogCount--;
}
}
Expand Down Expand Up @@ -687,7 +682,7 @@ static void xc_debug_dump(struct xc5000_priv *priv)
* Frame Lines needs two frame times after initial lock
* before it is valid.
*/
xc_wait(100);
msleep(100);

xc_get_ADC_Envelope(priv, &adc_envelope);
dprintk(1, "*** ADC envelope (0-1023) = %d\n", adc_envelope);
Expand Down Expand Up @@ -1137,7 +1132,7 @@ static int xc_load_fw_and_init_tuner(struct dvb_frontend *fe, int force)
* I2C transactions until calibration is complete. This way we
* don't have to rely on clock stretching working.
*/
xc_wait(100);
msleep(100);

if (priv->init_status_supported) {
if (xc5000_readreg(priv, XREG_INIT_STATUS, &fw_ck) != 0) {
Expand Down

0 comments on commit e5bf4a1

Please sign in to comment.