Skip to content

Commit

Permalink
ext4: remove lock_buffer in bclean() and setup_new_group_blocks()
Browse files Browse the repository at this point in the history
There is no need to lock the buffers since no one else should be
touching these buffers besides the file system.

Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Yongqiang Yang authored and Theodore Ts'o committed Jul 28, 2011
1 parent 6d40bc5 commit e6075e9
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions fs/ext4/resize.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,8 @@ static struct buffer_head *bclean(handle_t *handle, struct super_block *sb,
brelse(bh);
bh = ERR_PTR(err);
} else {
lock_buffer(bh);
memset(bh->b_data, 0, sb->s_blocksize);
set_buffer_uptodate(bh);
unlock_buffer(bh);
}

return bh;
Expand Down Expand Up @@ -229,10 +227,8 @@ static int setup_new_group_blocks(struct super_block *sb,
brelse(gdb);
goto exit_journal;
}
lock_buffer(gdb);
memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size);
set_buffer_uptodate(gdb);
unlock_buffer(gdb);
err = ext4_handle_dirty_metadata(handle, NULL, gdb);
if (unlikely(err)) {
brelse(gdb);
Expand Down

0 comments on commit e6075e9

Please sign in to comment.