Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 319419
b: refs/heads/master
c: a6e6507
h: refs/heads/master
i:
  319417: 33ae350
  319415: 73d14c6
v: v3
  • Loading branch information
Sachin Kamat authored and Inki Dae committed Jul 27, 2012
1 parent b080da6 commit e609116
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 30 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: edc572662a97773053a8d46a59794a08467f5115
refs/heads/master: a6e65072102a962e473cce5cf7aab0574bdf47e0
36 changes: 7 additions & 29 deletions trunk/drivers/gpu/drm/exynos/exynos_hdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ struct hdmi_context {
bool dvi_mode;
struct mutex hdmi_mutex;

struct resource *regs_res;
void __iomem *regs;
unsigned int external_irq;
unsigned int internal_irq;
Expand Down Expand Up @@ -2280,16 +2279,17 @@ static int __devinit hdmi_probe(struct platform_device *pdev)
return -EINVAL;
}

drm_hdmi_ctx = kzalloc(sizeof(*drm_hdmi_ctx), GFP_KERNEL);
drm_hdmi_ctx = devm_kzalloc(&pdev->dev, sizeof(*drm_hdmi_ctx),
GFP_KERNEL);
if (!drm_hdmi_ctx) {
DRM_ERROR("failed to allocate common hdmi context.\n");
return -ENOMEM;
}

hdata = kzalloc(sizeof(struct hdmi_context), GFP_KERNEL);
hdata = devm_kzalloc(&pdev->dev, sizeof(struct hdmi_context),
GFP_KERNEL);
if (!hdata) {
DRM_ERROR("out of memory\n");
kfree(drm_hdmi_ctx);
return -ENOMEM;
}

Expand Down Expand Up @@ -2318,26 +2318,18 @@ static int __devinit hdmi_probe(struct platform_device *pdev)
goto err_resource;
}

hdata->regs_res = request_mem_region(res->start, resource_size(res),
dev_name(dev));
if (!hdata->regs_res) {
DRM_ERROR("failed to claim register region\n");
ret = -ENOENT;
goto err_resource;
}

hdata->regs = ioremap(res->start, resource_size(res));
hdata->regs = devm_request_and_ioremap(&pdev->dev, res);
if (!hdata->regs) {
DRM_ERROR("failed to map registers\n");
ret = -ENXIO;
goto err_req_region;
goto err_resource;
}

/* DDC i2c driver */
if (i2c_add_driver(&ddc_driver)) {
DRM_ERROR("failed to register ddc i2c driver\n");
ret = -ENOENT;
goto err_iomap;
goto err_resource;
}

hdata->ddc_port = hdmi_ddc;
Expand Down Expand Up @@ -2398,16 +2390,9 @@ static int __devinit hdmi_probe(struct platform_device *pdev)
i2c_del_driver(&hdmiphy_driver);
err_ddc:
i2c_del_driver(&ddc_driver);
err_iomap:
iounmap(hdata->regs);
err_req_region:
release_mem_region(hdata->regs_res->start,
resource_size(hdata->regs_res));
err_resource:
hdmi_resources_cleanup(hdata);
err_data:
kfree(hdata);
kfree(drm_hdmi_ctx);
return ret;
}

Expand All @@ -2425,18 +2410,11 @@ static int __devexit hdmi_remove(struct platform_device *pdev)

hdmi_resources_cleanup(hdata);

iounmap(hdata->regs);

release_mem_region(hdata->regs_res->start,
resource_size(hdata->regs_res));

/* hdmiphy i2c driver */
i2c_del_driver(&hdmiphy_driver);
/* DDC i2c driver */
i2c_del_driver(&ddc_driver);

kfree(hdata);

return 0;
}

Expand Down

0 comments on commit e609116

Please sign in to comment.