Skip to content

Commit

Permalink
some clean up to intel-gtt.c
Browse files Browse the repository at this point in the history
In commit e517a5e the call to
map_page_into_agp() got removed from intel_i830_setup_flush(), but the
counterpart call from intel_i830_fini_flush() to unmap_page_from_agp()
was left in place.

Additionally, the page allocated here never gets its physical address
used for sending to hardware, so there's no need to allocate it with
GFP_DMA32. Nor is __GFP_ZERO really necessary, as the page is used
only to store data to force flushing of some internal processor state.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Jan Beulich authored and Chris Wilson committed Sep 24, 2010
1 parent 5ceb0f9 commit e61cb0d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/char/agp/intel-gtt.c
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,6 @@ static void i830_cleanup(void)
{
kunmap(intel_private.i8xx_page);
intel_private.i8xx_flush_page = NULL;
unmap_page_from_agp(intel_private.i8xx_page);

__free_page(intel_private.i8xx_page);
intel_private.i8xx_page = NULL;
Expand All @@ -826,7 +825,7 @@ static void intel_i830_setup_flush(void)
if (intel_private.i8xx_page)
return;

intel_private.i8xx_page = alloc_page(GFP_KERNEL | __GFP_ZERO | GFP_DMA32);
intel_private.i8xx_page = alloc_page(GFP_KERNEL);
if (!intel_private.i8xx_page)
return;

Expand Down

0 comments on commit e61cb0d

Please sign in to comment.