Skip to content

Commit

Permalink
DMI: remove duplicate helper routine
Browse files Browse the repository at this point in the history
Use existing dmi_get_system_info(),
Delete duplicate dmi_get_slot()

Spotted-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Len Brown committed Feb 3, 2008
1 parent 8964ebb commit e6298c6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 17 deletions.
12 changes: 6 additions & 6 deletions drivers/acpi/osl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1220,17 +1220,17 @@ int acpi_dmi_dump(void)
return -1;

printk(KERN_NOTICE PREFIX "DMI System Vendor: %s\n",
dmi_get_slot(DMI_SYS_VENDOR));
dmi_get_system_info(DMI_SYS_VENDOR));
printk(KERN_NOTICE PREFIX "DMI Product Name: %s\n",
dmi_get_slot(DMI_PRODUCT_NAME));
dmi_get_system_info(DMI_PRODUCT_NAME));
printk(KERN_NOTICE PREFIX "DMI Product Version: %s\n",
dmi_get_slot(DMI_PRODUCT_VERSION));
dmi_get_system_info(DMI_PRODUCT_VERSION));
printk(KERN_NOTICE PREFIX "DMI Board Name: %s\n",
dmi_get_slot(DMI_BOARD_NAME));
dmi_get_system_info(DMI_BOARD_NAME));
printk(KERN_NOTICE PREFIX "DMI BIOS Vendor: %s\n",
dmi_get_slot(DMI_BIOS_VENDOR));
dmi_get_system_info(DMI_BIOS_VENDOR));
printk(KERN_NOTICE PREFIX "DMI BIOS Date: %s\n",
dmi_get_slot(DMI_BIOS_DATE));
dmi_get_system_info(DMI_BIOS_DATE));

return 0;
}
Expand Down
9 changes: 0 additions & 9 deletions drivers/firmware/dmi_scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -489,12 +489,3 @@ int dmi_get_year(int field)

return year;
}

/**
* dmi_get_slot - return dmi_ident[slot]
* @slot: index into dmi_ident[]
*/
char *dmi_get_slot(int slot)
{
return(dmi_ident[slot]);
}
2 changes: 0 additions & 2 deletions include/linux/dmi.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ extern void dmi_scan_machine(void);
extern int dmi_get_year(int field);
extern int dmi_name_in_vendors(const char *str);
extern int dmi_available;
extern char *dmi_get_slot(int slot);

#else

Expand All @@ -90,7 +89,6 @@ static inline const struct dmi_device * dmi_find_device(int type, const char *na
static inline int dmi_get_year(int year) { return 0; }
static inline int dmi_name_in_vendors(const char *s) { return 0; }
#define dmi_available 0
static inline char *dmi_get_slot(int slot) { return NULL; }

#endif

Expand Down

0 comments on commit e6298c6

Please sign in to comment.