Skip to content

Commit

Permalink
opti621: fix deadlock on error handling
Browse files Browse the repository at this point in the history
* Stop abusing ide_lock lock (switch to a private locking).

  Fixes same issue as fixed by Alan Cox in atiixp host driver with
  commit 6c5f8cc.

* Bump driver version.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Oct 19, 2007
1 parent f949820 commit e65dde7
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/ide/pci/opti621.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* linux/drivers/ide/pci/opti621.c Version 0.8 Aug 27, 2007
* linux/drivers/ide/pci/opti621.c Version 0.9 Sep 24, 2007
*
* Copyright (C) 1996-1998 Linus Torvalds & authors (see below)
*/
Expand Down Expand Up @@ -133,6 +133,8 @@ static int reg_base;
#define PIO_NOT_EXIST 254
#define PIO_DONT_KNOW 255

static DEFINE_SPINLOCK(opti621_lock);

/* there are stored pio numbers from other calls of opti621_set_pio_mode */
static void compute_pios(ide_drive_t *drive, const u8 pio)
/* Store values into drive->drive_data
Expand Down Expand Up @@ -278,7 +280,7 @@ static void opti621_set_pio_mode(ide_drive_t *drive, const u8 pio)
second.recovery_time, drdy);
#endif

spin_lock_irqsave(&ide_lock, flags);
spin_lock_irqsave(&opti621_lock, flags);

reg_base = hwif->io_ports[IDE_DATA_OFFSET];

Expand Down Expand Up @@ -317,7 +319,7 @@ static void opti621_set_pio_mode(ide_drive_t *drive, const u8 pio)
/* and read prefetch for both drives */
write_reg(misc, MISC_REG);

spin_unlock_irqrestore(&ide_lock, flags);
spin_unlock_irqrestore(&opti621_lock, flags);
}

/*
Expand Down

0 comments on commit e65dde7

Please sign in to comment.