Skip to content

Commit

Permalink
x86: simplify __ioremap
Browse files Browse the repository at this point in the history
Remove tons of castings which make the code hard to read.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Thomas Gleixner authored and Ingo Molnar committed Feb 4, 2008
1 parent 63c1dcf commit e66aadb
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions arch/x86/mm/ioremap.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,8 @@ static int ioremap_change_attr(unsigned long paddr, unsigned long size,
static void __iomem *__ioremap(unsigned long phys_addr, unsigned long size,
enum ioremap_mode mode)
{
void __iomem *addr;
unsigned long pfn, offset, last_addr, vaddr;
struct vm_struct *area;
unsigned long pfn, offset, last_addr;
pgprot_t prot;

/* Don't allow wraparound or zero size */
Expand Down Expand Up @@ -164,19 +163,18 @@ static void __iomem *__ioremap(unsigned long phys_addr, unsigned long size,
if (!area)
return NULL;
area->phys_addr = phys_addr;
addr = (void __iomem *) area->addr;
if (ioremap_page_range((unsigned long)addr, (unsigned long)addr + size,
phys_addr, prot)) {
remove_vm_area((void *)(PAGE_MASK & (unsigned long) addr));
vaddr = (unsigned long) area->addr;
if (ioremap_page_range(vaddr, vaddr + size, phys_addr, prot)) {
remove_vm_area((void *)(vaddr & PAGE_MASK));
return NULL;
}

if (ioremap_change_attr(phys_addr, size, mode) < 0) {
vunmap(addr);
vunmap(area->addr);
return NULL;
}

return (void __iomem *) (offset + (char __iomem *)addr);
return (void __iomem *) (vaddr + offset);
}

/**
Expand Down

0 comments on commit e66aadb

Please sign in to comment.