Skip to content

Commit

Permalink
Input: input core - semaphore to mutex conversion
Browse files Browse the repository at this point in the history
Signed-off-by: Jes Sorensen <jes@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Jes Sorensen authored and Dmitry Torokhov committed Feb 19, 2006
1 parent 02860ab commit e676c23
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
15 changes: 8 additions & 7 deletions drivers/input/input.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <linux/interrupt.h>
#include <linux/poll.h>
#include <linux/device.h>
#include <linux/mutex.h>

MODULE_AUTHOR("Vojtech Pavlik <vojtech@suse.cz>");
MODULE_DESCRIPTION("Input core");
Expand Down Expand Up @@ -224,7 +225,7 @@ int input_open_device(struct input_handle *handle)
struct input_dev *dev = handle->dev;
int err;

err = down_interruptible(&dev->sem);
err = mutex_lock_interruptible(&dev->mutex);
if (err)
return err;

Expand All @@ -236,7 +237,7 @@ int input_open_device(struct input_handle *handle)
if (err)
handle->open--;

up(&dev->sem);
mutex_unlock(&dev->mutex);

return err;
}
Expand All @@ -255,13 +256,13 @@ void input_close_device(struct input_handle *handle)

input_release_device(handle);

down(&dev->sem);
mutex_lock(&dev->mutex);

if (!--dev->users && dev->close)
dev->close(dev);
handle->open--;

up(&dev->sem);
mutex_unlock(&dev->mutex);
}

static void input_link_handle(struct input_handle *handle)
Expand Down Expand Up @@ -512,13 +513,13 @@ static ssize_t input_dev_show_##name(struct class_device *dev, char *buf) \
struct input_dev *input_dev = to_input_dev(dev); \
int retval; \
\
retval = down_interruptible(&input_dev->sem); \
retval = mutex_lock_interruptible(&input_dev->mutex); \
if (retval) \
return retval; \
\
retval = sprintf(buf, "%s\n", input_dev->name ? input_dev->name : ""); \
\
up(&input_dev->sem); \
mutex_unlock(&input_dev->mutex); \
\
return retval; \
} \
Expand Down Expand Up @@ -790,7 +791,7 @@ int input_register_device(struct input_dev *dev)
return -EINVAL;
}

init_MUTEX(&dev->sem);
mutex_init(&dev->mutex);
set_bit(EV_SYN, dev->evbit);

/*
Expand Down
2 changes: 1 addition & 1 deletion include/linux/input.h
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ struct input_dev {

struct input_handle *grab;

struct semaphore sem; /* serializes open and close operations */
struct mutex mutex; /* serializes open and close operations */
unsigned int users;

struct class_device cdev;
Expand Down

0 comments on commit e676c23

Please sign in to comment.