Skip to content

Commit

Permalink
wl1271: read fem manufacturer value from nvs
Browse files Browse the repository at this point in the history
We should read the fem manufacturer value from the NVS, so we can modify it
easily and use a consistent value throughout the configuration.  Previously
we had to set the FEM value in the NVS and in the driver's initialization
parameters.  This patch removes the latter.

Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Luciano Coelho authored and John W. Linville committed Jul 8, 2010
1 parent 90494a9 commit e6b190f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 17 deletions.
6 changes: 3 additions & 3 deletions drivers/net/wireless/wl12xx/wl1271_cmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ int wl1271_cmd_general_parms(struct wl1271 *wl)
int wl1271_cmd_radio_parms(struct wl1271 *wl)
{
struct wl1271_radio_parms_cmd *radio_parms;
struct conf_radio_parms *rparam = &wl->conf.init.radioparam;
struct wl1271_ini_general_params *gp = &wl->nvs->general_params;
int ret;

if (!wl->nvs)
Expand All @@ -148,15 +148,15 @@ int wl1271_cmd_radio_parms(struct wl1271 *wl)
memcpy(&radio_parms->static_params_2, &wl->nvs->stat_radio_params_2,
sizeof(struct wl1271_ini_band_params_2));
memcpy(&radio_parms->dyn_params_2,
&wl->nvs->dyn_radio_params_2[rparam->fem].params,
&wl->nvs->dyn_radio_params_2[gp->tx_bip_fem_manufacturer].params,
sizeof(struct wl1271_ini_fem_params_2));

/* 5GHz parameters */
memcpy(&radio_parms->static_params_5,
&wl->nvs->stat_radio_params_5,
sizeof(struct wl1271_ini_band_params_5));
memcpy(&radio_parms->dyn_params_5,
&wl->nvs->dyn_radio_params_5[rparam->fem].params,
&wl->nvs->dyn_radio_params_5[gp->tx_bip_fem_manufacturer].params,
sizeof(struct wl1271_ini_fem_params_5));

wl1271_dump(DEBUG_CMD, "TEST_CMD_INI_FILE_RADIO_PARAM: ",
Expand Down
9 changes: 0 additions & 9 deletions drivers/net/wireless/wl12xx/wl1271_conf.h
Original file line number Diff line number Diff line change
Expand Up @@ -955,14 +955,6 @@ struct conf_radio_parms {
u8 fem;
};

struct conf_init_settings {
/*
* Configure radio parameters.
*/
struct conf_radio_parms radioparam;

};

struct conf_itrim_settings {
/* enable dco itrim */
u8 enable;
Expand Down Expand Up @@ -1029,7 +1021,6 @@ struct conf_drv_settings {
struct conf_rx_settings rx;
struct conf_tx_settings tx;
struct conf_conn_settings conn;
struct conf_init_settings init;
struct conf_itrim_settings itrim;
struct conf_pm_config_settings pm_config;
struct conf_roam_trigger_settings roam_trigger;
Expand Down
5 changes: 0 additions & 5 deletions drivers/net/wireless/wl12xx/wl1271_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,11 +241,6 @@ static struct conf_drv_settings default_conf = {
.keep_alive_interval = 55000,
.max_listen_interval = 20,
},
.init = {
.radioparam = {
.fem = 1,
}
},
.itrim = {
.enable = false,
.timeout = 50000,
Expand Down

0 comments on commit e6b190f

Please sign in to comment.