Skip to content

Commit

Permalink
USB: sisusbvga: Fix bug
Browse files Browse the repository at this point in the history
drivers/usb/misc/sisusbvga/sisusb.c: In function sisusb_open
drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: sisusb is used uninitialized in this function

is a genuine bug (which will cause oops). We cannot use "sisusb" in
error path for (!interface), because sisusb will itself be derived
from "interface" later.

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Satyam Sharma authored and Greg Kroah-Hartman committed Oct 12, 2007
1 parent 5adceac commit e6d42f0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/usb/misc/sisusbvga/sisusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -2440,10 +2440,8 @@ sisusb_open(struct inode *inode, struct file *file)
struct usb_interface *interface;
int subminor = iminor(inode);

if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
dev_err(&sisusb->sisusb_dev->dev, "Failed to find interface\n");
if (!(interface = usb_find_interface(&sisusb_driver, subminor)))
return -ENODEV;
}

if (!(sisusb = usb_get_intfdata(interface)))
return -ENODEV;
Expand Down

0 comments on commit e6d42f0

Please sign in to comment.