Skip to content

Commit

Permalink
x86/tools: Fix insn_sanity message outputs
Browse files Browse the repository at this point in the history
Fix x86 instruction decoder test to dump all error messages
to stderr and others to stdout.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: yrl.pp-manager.tt@hitachi.com
Link: http://lkml.kernel.org/r/20111205120550.15475.70149.stgit@cloud
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Masami Hiramatsu authored and Ingo Molnar committed Dec 5, 2011
1 parent bfbe901 commit e70825f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/x86/tools/insn_sanity.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ static void dump_stream(FILE *fp, const char *msg, unsigned long nr_iter,

fprintf(fp, "%s:\n", msg);

dump_insn(stderr, insn);
dump_insn(fp, insn);

fprintf(fp, "You can reproduce this with below command(s);\n");

Expand Down Expand Up @@ -260,7 +260,7 @@ int main(int argc, char **argv)
if (insn.next_byte <= insn.kaddr ||
insn.kaddr + MAX_INSN_SIZE < insn.next_byte) {
/* Access out-of-range memory */
dump_stream(stdout, "Error: Found an access violation", i, insn_buf, &insn);
dump_stream(stderr, "Error: Found an access violation", i, insn_buf, &insn);
errors++;
} else if (verbose && !insn_complete(&insn))
dump_stream(stdout, "Info: Found an undecodable input", i, insn_buf, &insn);
Expand Down

0 comments on commit e70825f

Please sign in to comment.