Skip to content

Commit

Permalink
[PATCH] x86-64: Revert timer routing behaviour back to 2.6.16 state
Browse files Browse the repository at this point in the history
By default route the 8254 over the 8259 and only disable
it on ATI boards where this causes double timer interrupts.

This should unbreak some Nvidia boards where the timer doesn't
seem to tick of it isn't enabled in the 8259. At least one
VIA board also seemed to have a little trouble with the disabled
8259.

For 2.6.20 we'll try both dynamically without black listing, but I think
for .19 this is the safer approach because it has been already well tested
in earlier kernels. This also makes the x86-64 behaviour the same
as i386.

Command line options can change all this of course.

Signed-off-by: Andi Kleen <ak@suse.de>
  • Loading branch information
Andi Kleen authored and Andi Kleen committed Oct 21, 2006
1 parent dbaab49 commit e70ea8c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
9 changes: 5 additions & 4 deletions arch/x86_64/kernel/early-quirks.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,11 @@ static void nvidia_bugs(void)

static void ati_bugs(void)
{
#if 1 /* for testing */
printk("ATI board detected\n");
#endif
/* No bugs right now */
if (timer_over_8254 == 1) {
timer_over_8254 = 0;
printk(KERN_INFO
"ATI board detected. Disabling timer routing over 8254.\n");
}
}

struct chipset {
Expand Down
2 changes: 1 addition & 1 deletion arch/x86_64/kernel/io_apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ static int no_timer_check;

static int disable_timer_pin_1 __initdata;

int timer_over_8254 __initdata = 0;
int timer_over_8254 __initdata = 1;

/* Where if anywhere is the i8259 connect in external int mode */
static struct { int pin, apic; } ioapic_i8259 = { -1, -1 };
Expand Down
2 changes: 2 additions & 0 deletions include/asm-x86_64/proto.h
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ extern int fix_aperture;
extern int reboot_force;
extern int notsc_setup(char *);

extern int timer_over_8254;

extern int gsi_irq_sharing(int gsi);

extern void smp_local_timer_interrupt(void);
Expand Down

0 comments on commit e70ea8c

Please sign in to comment.