Skip to content

Commit

Permalink
[PATCH] prism54: Free skb after disabling interrupts
Browse files Browse the repository at this point in the history
The dev_kfree_skb in islpci_eth_transmit happens while irqs are still
disabled, so either dev_kfree_skb_irq needs to be used or the skb
needs to be freed after irqs have been enabled again. This patch
should fix it.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Daniel Drake <dsd@gentoo.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Patrick McHardy authored and Jeff Garzik committed Oct 29, 2005
1 parent eef55ac commit e71180f
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/wireless/prism54/islpci_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,10 @@ islpci_eth_transmit(struct sk_buff *skb, struct net_device *ndev)
return 0;

drop_free:
/* free the skbuf structure before aborting */
dev_kfree_skb(skb);
skb = NULL;

priv->statistics.tx_dropped++;
spin_unlock_irqrestore(&priv->slock, flags);
dev_kfree_skb(skb);
skb = NULL;
return err;
}

Expand Down

0 comments on commit e71180f

Please sign in to comment.