Skip to content

Commit

Permalink
net: de4x5: Omit check for multicast bit in netdev_for_each_mc_addr
Browse files Browse the repository at this point in the history
There is no need to check for the address being a multicast address in
the netdev_for_each_mc_addr loop, so remove it.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tobias Klauser authored and David S. Miller committed Jul 1, 2011
1 parent b9ab82c commit e77aeb7
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/net/tulip/de4x5.c
Original file line number Diff line number Diff line change
Expand Up @@ -1964,9 +1964,7 @@ SetMulticastFilter(struct net_device *dev)
omr |= OMR_PM; /* Pass all multicasts */
} else if (lp->setup_f == HASH_PERF) { /* Hash Filtering */
netdev_for_each_mc_addr(ha, dev) {
addrs = ha->addr;
if ((*addrs & 0x01) == 1) { /* multicast address? */
crc = ether_crc_le(ETH_ALEN, addrs);
crc = ether_crc_le(ETH_ALEN, ha->addr);
hashcode = crc & HASH_BITS; /* hashcode is 9 LSb of CRC */

byte = hashcode >> 3; /* bit[3-8] -> byte in filter */
Expand All @@ -1977,7 +1975,6 @@ SetMulticastFilter(struct net_device *dev)
byte -= 1;
}
lp->setup_frame[byte] |= bit;
}
}
} else { /* Perfect filtering */
netdev_for_each_mc_addr(ha, dev) {
Expand Down

0 comments on commit e77aeb7

Please sign in to comment.