Skip to content

Commit

Permalink
thermal: step_wise: set throttle target within thermal instance limits
Browse files Browse the repository at this point in the history
When selecting a target cooling state in get_target_state(), make sure
that the state is at least as high as the minimum when the temperature
is rising and at least as low as the maximum when the temperature is
falling.  This is necessary because, in the THREAML_TREND_RAISING and
THERMAL_TREND_DROPPING cases, the current state may only be incremented
or decremented by one even if it is outside the bounds of the thermal
instance.  This might occur, for example, if the CPU is heating up
and hits a thermal trip point for the first time when it's frequency
is much higher than the range specified by the thermal instance
corresponding to the trip point.

Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
  • Loading branch information
Andrew Bresticker authored and Zhang Rui committed Apr 11, 2013
1 parent 8837295 commit e79fe64
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions drivers/thermal/step_wise.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,12 @@ static unsigned long get_target_state(struct thermal_instance *instance,

switch (trend) {
case THERMAL_TREND_RAISING:
if (throttle)
if (throttle) {
cur_state = cur_state < instance->upper ?
(cur_state + 1) : instance->upper;
if (cur_state < instance->lower)
cur_state = instance->lower;
}
break;
case THERMAL_TREND_RAISE_FULL:
if (throttle)
Expand All @@ -71,8 +74,11 @@ static unsigned long get_target_state(struct thermal_instance *instance,
if (cur_state == instance->lower) {
if (!throttle)
cur_state = -1;
} else
} else {
cur_state -= 1;
if (cur_state > instance->upper)
cur_state = instance->upper;
}
break;
case THERMAL_TREND_DROP_FULL:
if (cur_state == instance->lower) {
Expand Down

0 comments on commit e79fe64

Please sign in to comment.